Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ change button style #2096

Closed
wants to merge 9 commits into from

Conversation

DvoraShechter1
Copy link
Contributor

@DvoraShechter1 DvoraShechter1 commented Sep 16, 2024

add ActionsColumn to Job Functions table:
change the actions columun in the Job Functions table -
to use patternnfly 5 controls, instead of patternnfly 4 controls like in the Stakeholder table

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.01%. Comparing base (b654645) to head (56a0af3).
Report is 236 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2096      +/-   ##
==========================================
+ Coverage   39.20%   42.01%   +2.81%     
==========================================
  Files         146      175      +29     
  Lines        4857     5617     +760     
  Branches     1164     1406     +242     
==========================================
+ Hits         1904     2360     +456     
- Misses       2939     3136     +197     
- Partials       14      121     +107     
Flag Coverage Δ
client 42.01% <ø> (+2.81%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mguetta1 mguetta1 marked this pull request as draft September 18, 2024 17:15
@DvoraShechter1 DvoraShechter1 changed the title change button style ✨ change button style Sep 19, 2024
@DvoraShechter1 DvoraShechter1 changed the title ✨ change button style ✨ change button style Sep 19, 2024
jortel and others added 8 commits September 19, 2024 17:15
Related: konveyor/tackle2-hub#750

Signed-off-by: Jeff Ortel <jortel@redhat.com>
When a PR only contains changes to root level markdown, or anything
under `docs/` or `hack/`, there is no need to run the CI github actions.

To satisfy branch protection rules that may exist that require the
"unit-test" job to run, the `ci-repo.yml` action looks up details about
a PR and will skip the unit test if it detects that the only changes
made in the PR are docs or hacks.

The ignores do not apply to pushes to main, pushes to release, or
workflow calls.

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
To help out people building images in a fork, use github action
variables to be able to configure the target registry and image names.

Now on a fork, the destination of an image build can be set by using
action variables[^1]:
  - IMAGE_BUILD_REGISTRY (default: "quay.io/konveyor")
  - IMAGE_BUILD_IMAGE_NAME (default: "tackle2-ui")

and action secrets[^2]:
  - QUAY_PUBLISH_ROBOT
  - QUAY_PUBLISH_TOKEN

[^1]:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#creating-configuration-variables-for-a-repository
[^2]:
https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secret

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Updated the database after starting to see a few DB out-of-date
warnings.

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
…2093)

Resolves: konveyor#2094

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Fixes:
1. initial delay in first fetch - root cause was delayed initialization
of sentinel reference

2. extra page fetch request - algorithm based on items count was not
sufficient

Reference-Url:  konveyor#2049

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Scott Dickerson <sdickers@redhat.com>
Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
Changes:
1. add persistence provider to feature level persistence
(IFeaturePersistenceArgs) but not to table layer persistence
(ITablePersistenceArgs). This simplifies the provider code
(feature-specific providers).
2. remove meta-persistence target "default" - no target has the same
effect.
3. when in persistence provider mode use default values when the
deserialized value is nulish. This solves the problem of
initialFilterValues being overwritten in target cards scenario (the hook
is called more then once and useState() based logic fails to detect
initial load).

Using the newly added feature, store the filters selected in the Target
step (Analysis wizard) inside react-hook form in the same way as other
values.

Resolves: https://issues.redhat.com/browse/MTA-3438

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Scott Dickerson <sdickers@redhat.com>
Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
Signed-off-by: DvoraShechter1 <d0583212560@gmail.com>
@DvoraShechter1 DvoraShechter1 force-pushed the S&DjobFunctions branch 2 times, most recently from 683127d to e486984 Compare September 19, 2024 14:58
@DvoraShechter1 DvoraShechter1 deleted the S&DjobFunctions branch September 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants